wiseconnect: Adding SiWx917 Network Stack Application APIs #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragurram26
requested review from
Martinhoff-maker,
asmellby,
jerome-pouiller and
jhedberg
as code owners
ragurram26
changed the title
ragurram26
force-pushed
the
Embedded_TA_stack
branch
2 times, most recently
from
7a1b843 to
bf99442
Compare
|
@ragurram26 please follow the same guidelines for commit messages as is required in the main tree: https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines Also, please remove the revert commit and instead |
ragurram26
force-pushed
the
Embedded_TA_stack
branch
4 times, most recently
from
1d06dd3 to
32a7525
Compare
ragurram26
changed the title
jhedberg
requested changes
May 13, 2025
There was a problem hiding this comment.
We can't accept MSLA licensed files upstream. Also please note that since #97 was merged you likely need to sync up with that, and be sure to indicate which wiseconnect version you're importing the files from (btw, you need to also update the include script).
Comment on lines
9
to
14
| * The licensor of this software is Silicon Laboratories Inc. Your use of this | ||
| * software is governed by the terms of Silicon Labs Master Software License | ||
| * Agreement (MSLA) available at | ||
| * www.silabs.com/about-us/legal/master-software-license-agreement. This | ||
| * software is distributed to you in Source Code format and is governed by the | ||
| * sections of the MSLA applicable to Source Code. |
Comment on lines
9
to
14
| * The licensor of this software is Silicon Laboratories Inc. Your use of this | ||
| * software is governed by the terms of Silicon Labs Master Software License | ||
| * Agreement (MSLA) available at | ||
| * www.silabs.com/about-us/legal/master-software-license-agreement. This | ||
| * software is distributed to you in Source Code format and is governed by the | ||
| * sections of the MSLA applicable to Source Code. |
Comment on lines
6
to
11
| * The licensor of this software is Silicon Laboratories Inc. Your use of this | ||
| * software is governed by the terms of Silicon Labs Master Software License | ||
| * Agreement (MSLA) available at | ||
| * www.silabs.com/about-us/legal/master-software-license-agreement. This | ||
| * software is distributed to you in Source Code format and is governed by the | ||
| * sections of the MSLA applicable to Source Code. |
Comment on lines
9
to
14
| * The licensor of this software is Silicon Laboratories Inc. Your use of this | ||
| * software is governed by the terms of Silicon Labs Master Software License | ||
| * Agreement (MSLA) available at | ||
| * www.silabs.com/about-us/legal/master-software-license-agreement. This | ||
| * software is distributed to you in Source Code format and is governed by the | ||
| * sections of the MSLA applicable to Source Code. |
Comment on lines
6
to
11
| * The licensor of this software is Silicon Laboratories Inc. Your use of this | ||
| * software is governed by the terms of Silicon Labs Master Software License | ||
| * Agreement (MSLA) available at | ||
| * www.silabs.com/about-us/legal/master-software-license-agreement. This | ||
| * software is distributed to you in Source Code format and is governed by the | ||
| * sections of the MSLA applicable to Source Code. |
Comment on lines
6
to
11
| * The licensor of this software is Silicon Laboratories Inc. Your use of this | ||
| * software is governed by the terms of Silicon Labs Master Software License | ||
| * Agreement (MSLA) available at | ||
| * www.silabs.com/about-us/legal/master-software-license-agreement. This | ||
| * software is distributed to you in Source Code format and is governed by the | ||
| * sections of the MSLA applicable to Source Code. |
|
The commit message associated to this import is described here: https://docs.zephyrproject.org/latest/contribute/guidelines.html#identifying-contribution-origin In addition, can you update the list in For reference, check: FYI, the exact wiseconnect version currently used is 05ef77e82bb473fdf157d33fb9cbf6e1d9a11a9e (v3.5.0-rc3). |
|
@ragurram26 you have to rebase your PR rather merging with main branch (see https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-workflow). |
ragurram26
force-pushed
the
Embedded_TA_stack
branch
6 times, most recently
from
ef883c6 to
de789c9
Compare
scripts/import_wiseconnect.py
Outdated
| "components/service/network_manager/src/sl_net.c", | ||
| "components/service/network_manager/src/sl_net_credentials.c", | ||
| "components/service/sntp/si91x/sl_sntp.c", | ||
| "components/service/http_client/si91x_socket/sl_http_client.c", |
There was a problem hiding this comment.
This list of file is in fact sorted in alphabetical order.
|
Can you import the files in a separated commit (without change in |
ragurram26
force-pushed
the
Embedded_TA_stack
branch
4 times, most recently
from
941f6d1 to
a4ec11d
Compare
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
a4ec11d to
3edda6d
Compare
jerome-pouiller
approved these changes
May 15, 2025
ragurram26
force-pushed
the
Embedded_TA_stack
branch
11 times, most recently
from
4f591ae to
bfb5446
Compare
Origin: Silicon Labs WiseConnect SDK License: Zlib URL: https://github.com/siliconlabs/wiseconnect Commit: 05ef77e82bb473fdf157d33fb9cbf6e1d9a11a9e Version: v3.5.0-rc3 Purpose: To support the SiWx917 SNTP Network Stack Application protocol offloading, we need to add the Silicon Labs APIs, so adding the corresponding source files and include files Co-authored-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
Origin: Silicon Labs WiseConnect SDK License: Zlib URL: https://github.com/siliconlabs/wiseconnect Commit: 05ef77e82bb473fdf157d33fb9cbf6e1d9a11a9e Version: v3.5.0-rc3 Purpose: To support the SiWx917 HTTP Network Stack Application protocol offloading, we need to add the Silicon Labs APIs, so adding the corresponding source files and include files Co-authored-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Swami Das Nampalli <swami.das@silabs.com> Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
bfb5446 to
ed1d95f
Compare
Add SNTP, HTTP, MQTT, ICMP, Websockets, MDNS, DNS sdk files in import_wiseconnect.py Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
Origin: Silicon Labs WiseConnect SDK License: Zlib URL: https://github.com/siliconlabs/wiseconnect Commit: 05ef77e82bb473fdf157d33fb9cbf6e1d9a11a9e Version: v3.5.0-rc3 Purpose: To support the SiWx917 MQTT Network Stack Application protocol offloading, we need to add the Silicon Labs APIs, so adding the corresponding source files and include files Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
Origin: Silicon Labs WiseConnect SDK License: Zlib URL: https://github.com/siliconlabs/wiseconnect Commit: 05ef77e82bb473fdf157d33fb9cbf6e1d9a11a9e Version: v3.5.0-rc3 Purpose: To support the SiWx917 ICMP Network Stack Application protocol offloading, we need to add the Silicon Labs APIs, so adding the corresponding source files and include files Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
Origin: Silicon Labs WiseConnect SDK License: Zlib URL: https://github.com/siliconlabs/wiseconnect Commit: 05ef77e82bb473fdf157d33fb9cbf6e1d9a11a9e Version: v3.5.0-rc3 Purpose: To support the SiWx917 Websockets Network Stack Application protocol offloading, we need to add the Silicon Labs APIs,so adding the corresponding source files and include files Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
Origin: Silicon Labs WiseConnect SDK License: Zlib URL: https://github.com/siliconlabs/wiseconnect Commit: 05ef77e82bb473fdf157d33fb9cbf6e1d9a11a9e Version: v3.5.0-rc3 Purpose: To support the SiWx917 MDNS Network Stack Application protocol offloading, we need to add the Silicon Labs APIs,so adding the corresponding source files and include files Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
sl_strlen() and sl_strnlen() can be safely replaced by Posix equivalents. Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
To avoid any confusion between BSD sockets and Wiseconnect API, this patch just call the underlying functions (sli_si91x_shutdown()) instead of close(). sli_si91x_connect instead of connect() sli_si91x_send() intead of send() Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
Origin: Silicon Labs WiseConnect SDK License: Zlib URL: https://github.com/siliconlabs/wiseconnect Commit: 05ef77e82bb473fdf157d33fb9cbf6e1d9a11a9e Version: v3.5.0-rc3 Purpose: To support the SiWx917 DNS Network Stack Application protocol offloading, we need to add the Silicon Labs APIs,so adding the corresponding source files and include files Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
ragurram26
force-pushed
the
Embedded_TA_stack
branch
from
180635f to
60a35dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the SiWx917 Network Stack Application
protocol offloading, we need to add the Silicon Labs APIs,
so adding the corresponding source files and include files